Glows - second flag#2782
Merged
laspsandoval merged 3 commits intoIMAP-Science-Operations-Center:devfrom Feb 27, 2026
Merged
Conversation
maxinelasp
approved these changes
Feb 27, 2026
Contributor
maxinelasp
left a comment
There was a problem hiding this comment.
Looks good - just one suggestion!
Contributor
|
Addresses part of ticket #2721 |
3af8d2b
into
IMAP-Science-Operations-Center:dev
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the GLOWS L1b data processing by improving how sky regions are flagged for exclusion and updating related tests and flag definitions. The main update is the introduction of a new method to simultaneously flag bins close to UV sources and bins inside excluded sky regions, allowing for more precise masking during data processing. The changes also update the flag enumeration and refactor tests to use the new method.
Flagging improvements:
flag_uv_and_excludedmethod toHistogramL1B, which returns two boolean masks: one for bins close to UV sources and one for bins inside excluded sky regions, replacing the previousflag_uv_sourcemethod. [1] [2]_compute_histogram_flag_arrayto use the newflag_uv_and_excludedmethod, now correctly populating the "inside excluded region" flag row. [1] [2]Flag definition updates:
IS_INSIDE_EXCLUDED_REGIONflag to theGLOWSL1bFlagsenum inimap_processing/quality_flags.pyfor marking bins inside excluded regions.Test refactoring:
flag_uv_and_excludedinstead offlag_uv_source, ensuring test coverage for both UV source proximity and excluded region masking. [1] [2] [3] [4] [5] [6] [7] [8]Mock data improvements:
conftest.pyto provide deterministic longitude and latitude values for excluded regions, improving test reliability.