Glows - final flags#2787
Open
laspsandoval wants to merge 2 commits intoIMAP-Science-Operations-Center:devfrom
Open
Glows - final flags#2787laspsandoval wants to merge 2 commits intoIMAP-Science-Operations-Center:devfrom
laspsandoval wants to merge 2 commits intoIMAP-Science-Operations-Center:devfrom
Conversation
added 2 commits
February 27, 2026 15:34
Contributor
Author
|
@maxinelasp does this close this ticket too? #2688 Or is there more to do? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the GLOWS L1b data processing by implementing new per-bin quality flags for instrument team exclusions and suspected transients, improves the flagging logic, and updates tests and supporting data structures accordingly. The changes make the flagging system more robust and allow for more granular data quality tracking.
Enhancements to flagging logic and data structures:
IS_EXCLUDED_BY_INSTR_TEAMandIS_SUSPECTED_TRANSIENTto theGLOWSL1bFlagsenum inimap_processing/quality_flags.py, enabling more detailed quality tracking.flag_from_mask_datasetmethod inGLOWSL1bDatato retrieve per-bin boolean masks from xarray datasets, supporting the new exclusion and transient flags._compute_histogram_flag_arrayto populate the new flags using the mask datasets, and removed outdated TODOs now that the logic is implemented. [1] [2]Test and fixture improvements:
mock_ancillary_exclusionsfixture to provide realisticl1b_unique_block_identifierandhistogram_mask_arrayvalues for both instrument team exclusions and suspected transients, enabling more accurate testing. [1] [2]test_glows_l1b.pyto verify the correct operation offlag_from_mask_dataset, including shape and count checks for the exclusion mask.Minor code organization:
unique_block_identifierin__post_init__for clarity and to ensure correct initialization order.