Skip to content

ULTRA l1b stat cull validation test#2791

Merged
lacoak21 merged 15 commits intoIMAP-Science-Operations-Center:devfrom
lacoak21:ultra_l1b_stat_cull_validation_test
Mar 3, 2026
Merged

ULTRA l1b stat cull validation test#2791
lacoak21 merged 15 commits intoIMAP-Science-Operations-Center:devfrom
lacoak21:ultra_l1b_stat_cull_validation_test

Conversation

@lacoak21
Copy link
Contributor

@lacoak21 lacoak21 commented Mar 3, 2026

Change Summary

Overview

Add a validation test for the statistical outlier culling algorithm.

File changes

During the validation testing I realized I was modifying the std_diff array when recalculating the convergence after combining the flags. So that is the only part of the actual code that I had to update.

Testing

@lacoak21 lacoak21 added this to the March 2026 milestone Mar 3, 2026
@lacoak21 lacoak21 self-assigned this Mar 3, 2026
@lacoak21 lacoak21 added this to IMAP Mar 3, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a validation test for ULTRA L1B statistical outlier culling and adjusts the culling implementation to avoid mutating std_diff during the post-combine convergence recomputation.

Changes:

  • Removed std_diff mutation during the combined-mask convergence recomputation in flag_statistical_outliers.
  • Added an external-data validation test that compares culling flags/convergence/iterations/std-diff against precomputed results.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
imap_processing/ultra/l1b/ultra_l1b_culling.py Stops overwriting std_diff during convergence recomputation after combining flags across energy bins.
imap_processing/tests/ultra/unit/test_ultra_l1b_culling.py Adds an external-data validation test for statistical culling outputs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@subagonsouth subagonsouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lacoak21 lacoak21 merged commit 58adc91 into IMAP-Science-Operations-Center:dev Mar 3, 2026
22 of 23 checks passed
@lacoak21 lacoak21 deleted the ultra_l1b_stat_cull_validation_test branch March 3, 2026 22:17
@github-project-automation github-project-automation bot moved this to Done in IMAP Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants