ULTRA l1b stat cull validation test#2791
Merged
lacoak21 merged 15 commits intoIMAP-Science-Operations-Center:devfrom Mar 3, 2026
Merged
ULTRA l1b stat cull validation test#2791lacoak21 merged 15 commits intoIMAP-Science-Operations-Center:devfrom
lacoak21 merged 15 commits intoIMAP-Science-Operations-Center:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a validation test for ULTRA L1B statistical outlier culling and adjusts the culling implementation to avoid mutating std_diff during the post-combine convergence recomputation.
Changes:
- Removed
std_diffmutation during the combined-mask convergence recomputation inflag_statistical_outliers. - Added an external-data validation test that compares culling flags/convergence/iterations/std-diff against precomputed results.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
imap_processing/ultra/l1b/ultra_l1b_culling.py |
Stops overwriting std_diff during convergence recomputation after combining flags across energy bins. |
imap_processing/tests/ultra/unit/test_ultra_l1b_culling.py |
Adds an external-data validation test for statistical culling outputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
58adc91
into
IMAP-Science-Operations-Center:dev
22 of 23 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
Add a validation test for the statistical outlier culling algorithm.
File changes
During the validation testing I realized I was modifying the std_diff array when recalculating the convergence after combining the flags. So that is the only part of the actual code that I had to update.
Testing