-
Notifications
You must be signed in to change notification settings - Fork 9
Open
Description
Hello @sifaoufatai ,
Before implementing new functionnalities, I think it would be good to clean up the current version of your code and do some refactoring...
- the
bep32v01directory needs to be renamed because:
- you should not have a version number in the directory name
- it's not related to bep32 anymore (electrophy) but it is aimed at being more generic... so you can call it BIDSTools
(note that we should also rename the name of the full project, but let's ignore this for now, let's just deal with your code / directory!)
- about
launch.py
- it should be renamed into something else... for example CreateBIDSDataset.py, or something else; please discuss here and let's converge in this discussion before you implement!
- translate everything from french to english in your code! (variable names, comments etc.)
- rename the variables
config_pathandoutput_path: one is a file, the other one is a directory, so they should not be called with similar names (with bothpath)... to make the difference between files and directories, you can look at other big open source projects and see how they call files and directories (for ex. scikit learn) - simplify the code... lines like
json_path = config_pathoroutput = output_pathshould not exist!: use only one variable name, a meaningful one ;)
@killianrochet can check on all these details if I'm not available tomorrow!
Metadata
Metadata
Assignees
Labels
No labels