Merged
Conversation
- Fix Notification Log attributes name when creating - Add logs to the logger and remove it in console
…oupE-development Merge client changes according to Group C needs.
- Create FormMetadata file, defining fields - Added to A1, A2 and A3 forms
- Add token management in isSupervisor method (authMiddleware) - Change backend routes to get all forms - Delete Submission model - Update supervisor reminder: - Create a method that returns all forms with a specific filter - Delete post intership request because of submission used in formRoutes.js
- Create a new route to manage all forms:
- GET /api/supervisor/forms
- POST /api/supervisor/form/:type/:id/accept
- POST /api/supervisor/form/:type/:id/reject
- :type is form_type ("A1", "A2" or "A3")
- :id is the form id
- Add token management for authentification (Not used yet)
- Correct supervisor reminders:
- Find pending submissions in all forms table
- Send to all supervisor if we should remind
- Update supervisor reminder test with jest
- Update form metadata (reference to UserTokenRequest instead of User)
sanjay347
force-pushed
the
GroupE-development
branch
from
9430e87 to
573299d
Compare
Merge A3 frontend/backend integration into GroupE-development
…o GroupE-development
MRPHFitch
approved these changes
Apr 21, 2025
Charan-Nimmagadda
approved these changes
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Group E - Sprint 3 Pull Request
This pull request follows the pull request #104.
Integrate Pre-Sprint 3 improvements:
Fix Sprint 2 Bug:
Please do not merge this pull request until we mentioned you via Discord.