Groupe E - Sprint 1 API/UI Done#57
Merged
Charan-Nimmagadda merged 12 commits intomainfrom Apr 9, 2025
Merged
Conversation
Charan-Nimmagadda
requested changes
Apr 7, 2025
Collaborator
Charan-Nimmagadda
left a comment
Charan-Nimmagadda
left a comment
There was a problem hiding this comment.
You haven't included the changes from the other teams. I cannot merge this PR
Charan-Nimmagadda
requested changes
Apr 8, 2025
Charan-Nimmagadda
requested changes
Apr 9, 2025
Collaborator
Charan-Nimmagadda
left a comment
Charan-Nimmagadda
left a comment
There was a problem hiding this comment.
the table UI doesnt look good
Contributor
|
I updated the UI with the current version we have. sprint_1_dummy_test_data.txt |
Charan-Nimmagadda
requested changes
Apr 9, 2025
|
|
||
| const SupervisorDashboard = () => { | ||
| const [submissions, setSubmissions] = useState([]); | ||
| const url = "http://localhost:5001" |
Collaborator
There was a problem hiding this comment.
replace with process.env.REACT_APP_API_URL
| try { | ||
| const submission = await Submission.findByIdAndUpdate( | ||
| id, | ||
| { supervisor_status: "approved_by_supervisor" }, |
Collaborator
There was a problem hiding this comment.
Since we know it’s the status from the supervisor, let's set the value to Approved.
| try { | ||
| const submission = await Submission.findByIdAndUpdate( | ||
| id, | ||
| { supervisor_status: "rejected_by_supervisor" }, |
Collaborator
There was a problem hiding this comment.
Since we know it’s the status from the supervisor, let's set the value to Rejected.
Contributor
|
I have adjusted the requested code and pushed up to the repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.