remove emojis and rename RPC environment variable#50
remove emojis and rename RPC environment variable#50moltrus wants to merge 2 commits intoIQAIcom:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on improving compatibility and clarity within the project. It removes problematic emoji and Unicode characters from log outputs and internal labels to prevent parsing issues with tools like Claude Desktop. Additionally, it renames an environment variable for Polygon RPC to enhance its descriptive accuracy. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes emojis and Unicode characters from log messages and labels to prevent parsing issues, and renames the POLYMARKET_RPC_URL environment variable to POLYGON_RPC_URL for better clarity. The changes are well-aligned with the description. I've suggested one improvement to maintain backward compatibility for the renamed environment variable, which would make the transition smoother for existing users.
| const rpcUrl = | ||
| overrides.rpcUrl ?? | ||
| process.env.POLYMARKET_RPC_URL ?? | ||
| process.env.POLYGON_RPC_URL ?? |
There was a problem hiding this comment.
Description
Emoji Removal
Replaced all emojis and Unicode characters (like ✅, 📝, 🚀, and →) in log messages and internal labels with standard ASCII characters (true, false, and ->). Because MCP uses the same console (STDOUT) for data, Claude Desktop tries to parse that checkmark as JSON, fails, and stops loading the tools entirely.
Configuration Update: Renamed POLYMARKET_RPC_URL to POLYGON_RPC_URL.
This provides better clarity as the RPC specifically connects to the Polygon network rather than a Polymarket-specific infrastructure.