Merged
Conversation
… params in NewDatasetValidator
…re calling validation and repository method
MellyGray
reviewed
Jan 23, 2024
MellyGray
approved these changes
Jan 24, 2024
Contributor
MellyGray
left a comment
MellyGray
left a comment
There was a problem hiding this comment.
Looks good, thanks for applying the suggested changes
2 tasks
… into 110-create-dataset-use-case
Contributor
|
looks good, all tests passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR includes the createDataset use case. This new use case allows to create a dataset in Dataverse, given a NewDataset model and the collection id where the new dataset will be created.
Before calling the repository creation operation, the use case performs validation of the metadata fields of the different metadata blocks of the new dataset.
This validation throws validation errors of different subtypes, depending on the nature of the error. The most notable aspect of this error handling design is that from the errors generated, we can know which particular field is invalid. Given this information, this mechanism will allow error messages to be dynamically rendered within a form, such as the dataset creation form in the SPA.
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
This is the first resource creation operation in the module after the restructuring.
Suggestions on how to test this:
Check integration tests on GitHub actions or in local runs.