Merged
Conversation
Contributor
|
@MellyGray Can you please resolve conflicts? Please, do not prioritize this PR if you have other pending feature-related issues, which should be our focus for the community day. |
…vascript into 58-automatically-reformat-code
Contributor
Author
|
@GPortas merge conflicts resolved One question, should we merge this PR here to fix the markdown library? |
Contributor
|
Yes, I just accepted and merged the PR. Can you please resolve the conflicts? |
…vascript into 58-automatically-reformat-code
8608d6d to
c5d0a10
Compare
GPortas
reviewed
Mar 5, 2024
Contributor
Author
|
@GPortas did you ran npm install to install the pre-commit package? |
bc7c565 to
c5d0a10
Compare
Contributor
|
@MellyGray I missed that step, thanks! |
GPortas
approved these changes
Mar 5, 2024
Contributor
GPortas
left a comment
There was a problem hiding this comment.
LGTM
GitHub action registry push is failing since I had to force push to a previous commit to revert test commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What this PR does / why we need it:
This PR adds the automatic formatting to the repo using some pre-commit configurations. The pre-commits include:
A part from that:
as numberinstead of the real castingparseInt()and the tests were failing after changing from sinon assert to jest strict comparison.Which issue(s) this PR closes:
Special notes for your reviewer:
There are a lot of changes, but these are just formatting changes so they shouldn't affect the features.
Suggestions on how to test this: