-
Notifications
You must be signed in to change notification settings - Fork 10
39 - Module restructuring and rearchitecture #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
b28e6c7
Changed: updated dependencies and old package files moved to temporal…
GPortas bc7a9da
Changed: package.json description
GPortas 30ef551
Removed: unused tsfmt.json file
GPortas 9f0d125
Added: domain use case logic with initial sample use case
GPortas fb606d0
Added: use case error handling with unit tests and WIP of the reposit…
GPortas b68e650
Added: DataverseInfoRepository tests
GPortas 49bd7ae
Added: missing '^' prefix to package.json versions
GPortas 80568b5
Added: parametrized API URL for repository impl
GPortas 68a9067
Added: specific test type scripts (test:unit and test:integration)
GPortas 7157fd4
Refactor: test response extracted to variable
GPortas 4ce6c3e
Added: index.ts for 'info' module exports
GPortas b94975b
Added: package modules initialization
GPortas ad254f0
Removed: old package code
GPortas 07f2789
Removed: unnecessary packages
GPortas d72a3cd
Changed: updated README
GPortas ecac253
Removed: old test path ignore from jest configs
GPortas 36ccce7
Changed: issue and PR templates
GPortas ebf7f7e
Added: src index.ts
GPortas c92ea12
Removed: old docs
GPortas 25ada70
Fixed: missing package.json dependencies added
GPortas 58d9d38
Refactor: removed result model and handling errors with exceptions on…
GPortas 72ca474
Added: DataverseVersion model to include both version and build numbers
GPortas ba18a0a
Changed: README for using only npm and showing node version
GPortas 605f74e
Changed: issue templates format
GPortas e0ae1ef
Changed: README to better specify deps installation
GPortas d18dc9b
Refactor: using private readonly in constructor
GPortas 05791e5
Refactor: axios path sequental reading
GPortas 1b2412f
Refactor: removed unnecessary variable
GPortas ef8d69b
Refactor: string concat in ReadError
GPortas 892ece2
Changed: package-lock
GPortas 8661503
improve README.md and CONTRIBUTING.md #39
pdurbin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "root": true, | ||
| "parser": "@typescript-eslint/parser", | ||
| "plugins": ["@typescript-eslint", "jest"], | ||
| "extends": [ | ||
| "eslint:recommended", | ||
| "plugin:@typescript-eslint/recommended", | ||
| "plugin:jest/recommended" | ||
| ] | ||
| } |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| ## What steps does it take to reproduce the issue? | ||
|
|
||
| ## When does this issue occur? | ||
|
|
||
| ## What happens? | ||
|
|
||
| ## What did you expect to happen? | ||
|
|
||
| ## Which version of js-dataverse are you using? | ||
|
|
||
| ## Any related open or closed issues to this bug report? | ||
|
|
||
| ## Screenshots: | ||
|
|
||
| No matter the issue, screenshots are always welcome. | ||
|
|
||
| To add a screenshot, please use one of the following formats and/or methods described here: | ||
|
|
||
| - https://help.github.com/en/articles/file-attachments-on-issues-and-pull-requests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| ## Overview of the feature request | ||
|
|
||
| ## What inspired the request? | ||
|
|
||
| ## What existing behavior do you want changed? | ||
|
|
||
| ## Any brand new behavior do you want to add to js-dataverse? | ||
|
|
||
| ## Any open or closed issues related to this feature request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,13 @@ | ||
| ## Description | ||
| <Description of the pull request> | ||
| ## What this PR does / why we need it: | ||
|
|
||
| ## Changes | ||
| <A list of the changes that have been made> | ||
| ## Which issue(s) this PR closes: | ||
|
|
||
| ## Tests | ||
| <A brief description of how the functionality has been tested> | ||
| - Closes # | ||
|
|
||
| ## Checklist | ||
| [] The project builds | ||
| [] The project passes lint checks | ||
| [] The project passes format checks | ||
| [] The project passes unit tests | ||
| [] I've manually tested the functionality | ||
| ## Special notes for your reviewer: | ||
|
|
||
| ## Screenshots | ||
| <Screenshots of new functionality if available> | ||
| ## Suggestions on how to test this: | ||
|
|
||
| ## Additional information | ||
| ## Is there a release notes update needed for this change?: | ||
|
|
||
| ## Additional documentation: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "printWidth": 120, | ||
| "trailingComma": "all", | ||
| "singleQuote": true | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.