Skip to content

Comments

115 - Dataset summary continued#118

Merged
kcondon merged 15 commits intodevelopfrom
feature/115-dataset-summary-continued
Jun 28, 2023
Merged

115 - Dataset summary continued#118
kcondon merged 15 commits intodevelopfrom
feature/115-dataset-summary-continued

Conversation

@MellyGray
Copy link
Contributor

@MellyGray MellyGray commented Jun 14, 2023

What this PR does / why we need it:

Originally from a comment Philip left at #112 (comment)

After some discussion in the frontend meeting we decided to do the following changes in this PR:

  1. Handle Persistent Identifier, Publication Date, Citation Date and Alternative Persistent Id to show them in the Citation Metadata accordion if they apply.
  • I added the frontend logic, but the e2e won't display these fields until this change is implemented in js-dataverse. See #66, #65, #64
  1. For Author No separation between name, affiliation, identifier type, and identifier. Affiliation should be in parentheses.
  • I added the frontend logic, but the e2e is mocked until this issue is implemented in js-dataverse. See #63
  1. ORCID there is no link
  • No changes applied regarding the ORCID link in this PR. I'd prefer to see how this change is handled in the API/js-dataverse. If this is finally applied using displayFormat, then no change will be required in the frontend. I created a frontend issue to keep track of this in case some change is needed Display the authorIdentifier metadata field as a link #119
  1. For Point of Contact
    For privacy reasons, the email should be hidden. Instead we mention a button (that doesn't exist yet in the SPA). See also https://guides.dataverse.org/en/5.13/installation/config.html#email-privacy
  • Hidding the email needs to be applied in the backend so it never reaches the SPA. So it'll keep showing until changes are applied to the API
  • Message 'Use email button above to contact.' added to this PR

Which issue(s) this PR closes:

Special notes for your reviewer:

Read carefully the description above. In summary, I only applied frontend changes but the backend work is pending.

Suggestions on how to test this:

  1. Follow steps described at 95 - Invoke js dataverse use cases in the dataset page #112 to run the application using the development environment
  2. As I explained above, the backend work is pending, so the only way to check the changes is by going to the Storybook and looking at the Dataset page with the mocked data.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

The correct one is the left one:
Screen Shot 2023-05-31 at 4 11 27 PM

Is there a release notes update needed for this change?:

Additional documentation:

@MellyGray MellyGray linked an issue Jun 14, 2023 that may be closed by this pull request
@MellyGray MellyGray marked this pull request as ready for review June 15, 2023 13:09
@MellyGray MellyGray added the Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) label Jun 15, 2023
@ekraffmiller ekraffmiller self-assigned this Jun 15, 2023
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I can see the expected changes in the Data Summary section, approved the changes in Chromatic.

@kcondon kcondon self-assigned this Jun 21, 2023
@kcondon
Copy link
Contributor

kcondon commented Jun 28, 2023

@MellyGray I'm seeing an additional field in storybook, previous dataset. What is that?

Screen Shot 2023-06-28 at 10 57 17 AM

@kcondon kcondon merged commit 6663e29 into develop Jun 28, 2023
@kcondon kcondon deleted the feature/115-dataset-summary-continued branch June 28, 2023 15:25
@cmbz cmbz added pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows labels Jan 29, 2024
jayanthkomarraju pushed a commit to jayanthkomarraju/dataverse-frontend that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 30 A percentage of a sprint. 21 hours. (formerly size:33)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dataset summary, continued [Spike - Frontend] Dataset summary, continued

5 participants