Merged
Conversation
…lay correctly the metadata fields
ekraffmiller
approved these changes
Jun 20, 2023
Contributor
ekraffmiller
left a comment
There was a problem hiding this comment.
Looks good - I can see the expected changes in the Data Summary section, approved the changes in Chromatic.
…ture/115-dataset-summary-continued
Contributor
|
@MellyGray I'm seeing an additional field in storybook, previous dataset. What is that?
|
jayanthkomarraju
pushed a commit
to jayanthkomarraju/dataverse-frontend
that referenced
this pull request
May 31, 2024
…tinued 115 - Dataset summary continued
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What this PR does / why we need it:
Originally from a comment Philip left at #112 (comment)
After some discussion in the frontend meeting we decided to do the following changes in this PR:
For privacy reasons, the email should be hidden. Instead we mention a button (that doesn't exist yet in the SPA). See also https://guides.dataverse.org/en/5.13/installation/config.html#email-privacy
Which issue(s) this PR closes:
Special notes for your reviewer:
Read carefully the description above. In summary, I only applied frontend changes but the backend work is pending.
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
The correct one is the left one:

Is there a release notes update needed for this change?:
Additional documentation: