Conversation
GPortas
force-pushed
the
feature/repo_config
branch
from
5993142 to
6d9012c
Compare
pdurbin
reviewed
Mar 7, 2023
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
Overall this looks good. I made one tiny suggestion to make the title of issues appear under "closes".
| @@ -0,0 +1,7 @@ | |||
| # Security | |||
|
|
|||
| To report a security vulnerability please email security@dataverse.org as explained at https://guides.dataverse.org/en/latest/installation/config.html#reporting-security-issues | |||
Member
There was a problem hiding this comment.
We could also try using this new feature of GitHub: https://github.blog/changelog/2022-11-09-privately-report-vulnerabilities-to-repository-maintainers/
No rush, of course. 😄 No need to hold up with pull request.
GPortas
force-pushed
the
feature/repo_config
branch
from
9f62872 to
a68e8a2
Compare
pdurbin
approved these changes
Mar 8, 2023
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
This is looking great. Thanks, @GPortas!
He and I had a long, sprawling conversation this morning about SECURITY.md and the need for a CONTRIBUTING.md but we'll continue with this in future efforts.
We also added a "WIP" (Work In Progress) badge to indicate the status of this repo.
Approved!
jayanthkomarraju
pushed a commit
to jayanthkomarraju/dataverse-frontend
that referenced
this pull request
May 31, 2024
2 - Issue and PR templates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Includes the issue and PR templates related to #2.
In the context of #2, and despite the fact that these changes are already established as they are independent of code changes, new tags have been created for issue management.
Specifically, the new tags are:
Which issue(s) this PR closes:
Closes #2
Special notes for your reviewer:
N/A
Suggestions on how to test this:
N/A
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
N/A
Additional documentation:
N/A