Fix/528 Use fields from parent - Create Collection form behavior#540
Merged
ofahimIQSS merged 5 commits intodevelopfrom Nov 8, 2024
Merged
Conversation
Contributor
|
This change is causing an error in Create Dataset, when the parent collection is not the Root. We need a fix in the Dataverse API to get the correct metadata fields for the Create Dataset form. Added a waiting tag to this issue. createDatasetTest.mov |
Contributor
Author
|
@ekraffmiller working great on my end after pulling new unstable dataverse image. Screen.Recording.2024-11-05.at.14.49.43.mov |
Contributor
Working for me now too, needed to get the newest image |
ekraffmiller
approved these changes
Nov 6, 2024
Contributor
ekraffmiller
left a comment
There was a problem hiding this comment.
looks good, approving 👍
Contributor
|
No issues found during testing. Merging PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In the Create Collection form, when the user checks the “Use fields from [parent]” checkbox, we are now sending metadata block names and input levels as undefined to the js-dataverse use case.
This was tested also using the GHCR container image generated from IQSS/dataverse#10985 PR and it works great.
This comment from @pdurbin explains what this is fixing very well.
Which issue(s) this PR closes:
Suggestions on how to test this:
Step 1: Run the Development Environment
npm i.cd packages/design-system && npm i && npm run build.cd ../../..envfile similar to.env.example, with the variableVITE_DATAVERSE_BACKEND_URL=http://localhost:8000.cd dev-env../run-env.sh unstable.Step 2: Test the fix
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
No
Additional documentation:
No