Merged
Conversation
Contributor
ekraffmiller
left a comment
ekraffmiller
left a comment
There was a problem hiding this comment.
This works really well! Some questions/comments added
tests/component/sections/edit-collection/EditCollection.spec.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@ekraffmiller all requested changes have been addressed, let me know if I have missed anything. Thanks! |
ekraffmiller
approved these changes
Nov 25, 2024
Contributor
ekraffmiller
left a comment
ekraffmiller
left a comment
There was a problem hiding this comment.
looks great, approved!
Contributor
Author
|
Removing waiting tag since IQSS/dataverse-client-javascript#215 and IQSS/dataverse#11026 have been merged. |
g-saracca
added
Size: 3
Contributor
|
Tested in local no issues found during testing. Screen.Recording.2024-12-16.at.10.00.50.AM.movOne observation made during testing of storybook > Pages /Edit Collection
The two messaging boxes aren't aligned the same |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds the edit collection page in the SPA.
Reuses the form to create a collection with a few refactors to be able to work for both modes (create and edit).
Which issue(s) this PR closes:
Special notes for your reviewer:
This can be reviewed as it is now, but for QA purposes I would wait until these two issues are merged first:
Suggestions on how to test this:
Step 1: Run the Development Environment
npm i.cd packages/design-system && npm i && npm run build.cd ../../..envfile similar to.env.example, with the variableVITE_DATAVERSE_BACKEND_URL=http://localhost:8000.cd dev-env../run-env.sh unstable.Step 2: Test the feature
Create subcollections and edit them, go to edit them again and validate that the fields are changed.
Validate that works similar as in the JSF version.
Also validate that when editing the root collection the form also looks the same way as in JSF.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No, pretty much the same UI from the create collection page.
Is there a release notes update needed for this change?:
No
Additional documentation:
No