Merged
Conversation
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
|
@g-saracca Thanks! Merged! |
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The initial scope of this issue was to support File Preview External Tools. However, since the endpoint introduced by @qqmyers in this PR already covers all tool types, I extended this work to support all external tool types used within the app. Not sure if I'm missing something.
Dataset Page:
File Page:
If only one file applicable tool and is preview, the tab will show "Preview" title. Storybook example.
If only one file applicable tool and is query, the tab will show "Query" title. Storybook example.
If more than one file applicable tool, the tab will show "File Tools". Storybook example.
Which issue(s) this PR closes:
Special notes for your reviewer:
Please note that we are using a JS-Dataverse PR generated package version because related backend PR is In Review.
I've fixed some styling related to button groups in vertical mode when buttons inside of it contained tooltips.
I've also moved the loading provider/context to a shared
/contextsfolder.I've added some unit tests but not sure if worth or how to add integration tests for this. Also the
window.openis not working correctly on the CI tests due to an issue with Electron so I skipped testing that part.Suggestions on how to test this:
In order to test the visibility of these external tools you will need to first upload them on your local setup with the admin endpoint:
/api/admin/externalTools(POST), ping me and I can share some json examples of different tools that I grab from HDV installation, they should be enough to test the visibility of every external tool in the UI.Compare with the JSF version to validate we are following the same permissions approach.
Does this PR introduce a user interface change? If mockups are available, please link/include them here: Yes.
Access Dataset dropdown => Explore Tool options
Edit Dataset dropdown => Configure Tool options
Files Table => File => Preview and Query buttons
Files Table => File => Access File => Explore and Query Tool options
Files Table => File => Edit File => Configure Tool options
Access File dropdown => Explore and Query Tool options
Edit File dropdown => Configure Tool options
Preview tab => Preview and Query Tool options.
More than one tool applicable for the file type.
Is there a release notes update needed for this change?:
No
Additional documentation:
N/A