Skip to content

Suggestion: use Charsets instead of strings in SAVFileReader #10773

@bencomp

Description

@bencomp

Overview of the Suggestion
SAVFileReader defines a defaultCharset variable as a String and uses it to convert between strings and bytes.
@stevenwinship suggested in a comment on #10077 to use StandardCharsets in those locations, but because there is some interaction with the API and UI, I wasn't sure that a find-and-replace would work. At some point, I expect that the name of a Charset is exchanged between UI and backend as a string, which would need a look-up to convert it into a Charset.

What kind of user is the suggestion intended for?
(Example users roles: API User, Curator, Depositor, Guest, Superuser, Sysadmin)
Developers, QA

What inspired this idea?
#10077 (comment)

What existing behavior do you want changed?
Nothing in how Dataverse works should change.

Any brand new behavior do you want to add to Dataverse?
No.

Any open or closed issues related to this suggestion?
#10076

Are you thinking about creating a pull request for this issue?
No. I don't know how the current UI influences what kind of solution is needed and I have no experience with SAV files. The SAVFileReader is quite a big class with details that I don't understand.

I fully understand if this issue is closed as not planned, but I promised to open it, so here it is.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions