stop using v3 of download-artifact and upload-artifact

[pdurbin]

From https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

"Starting November 30, 2024, GitHub Actions customers will no longer be able to use v3 of actions/upload-artifact or actions/download-artifact. Customers should update workflows to begin using v4 of the artifact actions as soon as possible. While v4 of the artifact actions improves upload and download speeds by up to 98% and includes several new features, there are key differences from previous versions that may require updates to your workflows. Please see the documentation in the project repositories for guidance on how to migrate your workflows."

We tried to upgrade in this PR but saw failures:

• Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows #10822

We should try again, soon. And we should compare notes with the frontend:

• Stop using v3 of download-artifact and upload-artifact dataverse-frontend#537

[cmbz]

2024/10/31: Due to urgency of issue, confusing documentation, and unknown size, I'm moving this into this sprint immediately.

Edited to add: Current size 30 is an estimate. Please resize this issue as needed.