Dataset Publish/Submit for Review - Optimize Button/Popup Code

[mheppler]

Find a better way to have markup and render logic on the dataset page for all the different Publish/Submit for Review buttons and popups. There are currently eight buttons at the top of the page with seven popups.

• Submit for Review - inreview.show()
• Register - registerDataset()
• Reject - sendBackToContributor.show()
• Publish - confirmation.show()
• Publish - releaseDraft.show()
• Publish - mayNotRelease.show()
• Publish - publishParent.show()
• Publish - maynotPublishParent.show()

[mheppler]

Looked at this in more detail as part of the work for #3747 and #3849. The main issue is that there are 5 different "Publish" buttons that point to 5 different popups. The render logic for these 5 buttons have two piece of render logic in common:

DatasetPage.dataset.latestVersion.versionState=='DRAFT' 
and permissionsWrapper.canIssuePublishDatasetCommand(DatasetPage.dataset)

Using those as the only render logic, for only one "Publish" button, we can move the rest of the render logic to either the onclick attribute or to the body of the dialog -- which would also allow us to not require 5 different publish popups.

All the conditional render logic needed for the publish popups is determining if we allow you publish or not, and which header, help text and buttons to display in the popup. That logic is not needed in the "Publish" button code and only complicates the button display logic.

This is something worth looking into when we address UI Cleanup - Action Button + Metrics Block Layout #3341.