Citation: Still has hard coded values, not fully implemented.

[eaquigley]

---

Author Name: Kevin Condon (@kcondon)
Original Redmine Issue: 3588, https://redmine.hmdc.harvard.edu/issues/3588
Original Date: 2014-02-25
Original Assignee: Kevin Condon

---

From 2/21/14 Smoke test

Citation: Still has hard coded values, not fully implemented.

[eaquigley]

---

Original Redmine Comment
Author Name: Steve Kraffmiller (@sekmiller)
Original Date: 2014-02-28T16:58:22Z

---

This is what we want to see per Eleni email:

Author(s),
Year, Dataset Title, Global Persistent Identifier,
Data Repository or Archive [publisher],
version.

All of these fields are now pulled from the saved data. doi is not being registered for now - even on test site.

[eaquigley]

---

Original Redmine Comment
Author Name: Philip Durbin (@pdurbin)
Original Date: 2014-03-03T20:38:15Z

---

• use on dataset card (and no more "LastName, FirstName") in search-include-fragement.xhtml
• update the publisher to the root dataverse instead of owning dataverse
• review authors to make sure they're right (Eleni's email... empty author? study doesn't have an author? Ask Mike)

[eaquigley]

---

Original Redmine Comment
Author Name: Philip Durbin (@pdurbin)
Original Date: 2014-03-04T01:10:29Z

---

I just fixed the citation on the dataset card. (And removed the hardcoded "LastName, FirstName").

Stephen, can you please delete the old methods if they aren't to be
used anymore? I left some todo's at
src/main/java/edu/harvard/iq/dataverse/DatasetVersion.java

/**
* @todo: delete this method? It seems to have been replaced by the version
* in DatasetVersionUI
*/
public String getCitation() {
return getCitation(true);
}

/**
* @todo: delete this method? It seems to have been replaced by the version
* in DatasetVersionUI
*/
public String getCitation(boolean isOnlineVersion) {

my commit: 58f835a

Also, I just noticed that I'm getting an NPE: edu.harvard.iq.dataverse.DatasetVersionUI.(DatasetVersionUI.java:77)

Here's line 77:

if(datasetAuthor.getFirstName().isEmpty() && !datasetAuthor.getLastName().isEmpty()){

Possibly something to take a look at. I added more error checking in SearchIncludeFragment.java to handle it (commit b3ad055).

[eaquigley]

---

Original Redmine Comment
Author Name: Kevin Condon (@kcondon)
Original Date: 2014-03-04T21:12:10Z

---

Tested on 3/14

Hard coded values are gone.

There are still issues with citation but will be tracked in a separate ticket.

Closing ticket