use enum for possible fieldTypes

[eaquigley]

---

Author Name: Philip Durbin (@pdurbin)
Original Redmine Issue: 3783, https://redmine.hmdc.harvard.edu/issues/3783
Original Date: 2014-03-26
Original Assignee: Steve Kraffmiller

---

This ticket is a placeholder for this thread:

From: Philip Durbin <philip_durbin@harvard.edu>
Date: Thu, Mar 20, 2014 at 8:33 AM
Subject: textBox or textbox? source of truth for possible fieldTypes?
To: Dataverse Team

textbox, text, date, email, and url and the current types defined at https://docs.google.com/spreadsheet/ccc?key=0AjeLxEN77UZodHFEWGpoa19ia3pldEFyVFR0aFVGa0E&usp=sharing

We're thinking we should make an enum (or something) the source of truth for this list of fieldTypes and refactor the code accordingly. Solr needs to know the types up front to avoid runtime exceptions while indexing.

Also, maybe we should call it textarea rather than text or textbox since that's what it is in HTML.

[eaquigley]

---

Original Redmine Comment
Author Name: Philip Durbin (@pdurbin)
Original Date: 2014-04-30T12:37:50Z

---

Philip Durbin wrote:

textbox, text, date, email, and url and the current types defined

There are also "float" and "int" types and the "email" type was apparently dropped? This seems to be a somewhat reliable way of getting the list of possible types:

murphy:dataverse pdurbin$ cat scripts/api/data/metadatablocks/*.tsv | cut -f6 | sort -u

 fieldType
date
float
int
text
textbox
url

Basically, whatever is typed into the Google Spreadsheet becomes a type. We can't have this. We need to define the list of possible types ahead of time (in an enum or whatever) before a new type is added into the Google Spreadsheet.

[eaquigley]

---

Original Redmine Comment
Author Name: Philip Durbin (@pdurbin)
Original Date: 2014-05-13T13:41:34Z

---

This class would probably benefit from the fieldType enum as well:

https://github.com/IQSS/dataverse/blob/master/src/main/java/edu/harvard/iq/dataverse/DatasetFieldValueValidator.java

I has hard-coded types such as "textbox" etc.

[eaquigley]

@pdurbin & @sekmiller what is the status of this?

[pdurbin]

I still very much want this. Right now I'm still doing string comparison such as fieldType.equals("date") at

dataverse/src/main/java/edu/harvard/iq/dataverse/DatasetFieldType.java

Line 350 in ecdfaa0

if (fieldType.equals("date")) {

I'd rather be checking an enum.