"Submitted for Review" message appearing on published versions of datasets can confuse dataset contributors and curators/admins

[jggautier]

After this workflow...

• The depositor creates a dataset and submits it for review
• the dataset is published by a curator
• the depositor edits the dataset and submits a second version of the dataset for review

... the yellow "Submitted for Review" message exists on all versions of the dataset, although only the draft version is actually submitted for review. The first version is already published/publicly accessible.

The message appearing on pages of published dataset versions can be confusing to the researcher who's deposited the dataset because it looks like the dataset has never been published.

It can also be confusing to the curator who lands on an already published version of the dataset, but sees the "Submitted for Review" message, and doesn't know how to publish or return the dataset. (Doesn't know to click on the draft version link in the versions tab.)

This message is also displayed to users who have no access to the dataset, including guest users not logged in.

Message on draft version page of dataset:

Message on first published version of dataset:

This is seen on Harvard Dataverse and demo.dataverse running 4.8.4.

[djbrooke]

Thanks @jggautier. This was noticed during load testing for the move to AWS.

[mheppler]

This message is also displayed to user without any access related to the dataset, as well as guest users not logged in.

[pdurbin]

I assume that this used to work fine but a regression slipped in. @jggautier and @mheppler seem to be talking about version 4.8.4, which is what's in production as of this writing.

[jggautier]

@djbrooke, @mheppler, @sbarbosadataverse, @dlmurphy and @TaniaSchlatter discussed this briefly and agreed that everyone (anyone logged out or logged in with permissions on the dataset) should see the message only on the draft version of the dataset. Already published dataset versions should not have this message.

This issue was prompted by a support ticket from a dataverse curator who landed on an earlier, already published version of a dataset, saw the "Submitted for Review" message, and didn't know how to publish or return the dataset. He didn't know to click on the draft version link in the versions tab. I think our proposal to remove the message from all versions of the dataset that this curator sees would not help him realize that he needs to navigate to the draft version of the dataset in order to publish or return to it to the author. But we agreed that this scenario happens very rarely - we have no evidence that curators often land on older versions of datasets whose drafts they need to publish or return to the author - so it doesn't need to be considered at this point.

[pdurbin]

@matthew-a-dunlap and I just discussed this regression. In my case I wasn't logged in but I can see the "Submitted for Review" message: