Internationalization : remove English static strings from Java files to bundle.properties

[JayanthyChengan]

Example 1:
src/main/java/edu/harvard/iq/dataverse/authorization/Permission.java [ Line 37 to 52]

Example 2:
src/main/java/edu/harvard/iq/dataverse/Dataset.java [ Line 436 to 444 ]

[pdurbin]

I just left the following review on pull request #4785

Overall, looks great. I didn't realize how much English is still hard coded in the Java code. I did find a couple places where it looks like we're considering moving from hard-coded English strings to Bundle entries but the switch hasn't been made yet and I'm wondering why. I left comments on these lines.

@JayanthyChengan thanks for leading the charge on internationalization! Note that @pengchengluo is also working away on #4784

[djbrooke]

Hi @JayanthyChengan - do you have any guidance on QAing this, or any previous test case information that would be helpful for us?

[JayanthyChengan]

Please refer to the spreadsheet which we used for UI testing at ScholarsPortal:
https://docs.google.com/spreadsheets/d/1Nr9ZVBRkLULZ3uyjXNuA7oxQeR2KpXrxdYK6Ix695BA

[djbrooke]

Great, thanks!