Guestbook - Broken Datatset/File Pg UI

[mheppler]

A support issue came in for a dataset on production that -- among other things -- had a broken Guestbook form at the bottom of the dataset pg (also discovered to be broken on the file pg as well).

Was able to replicate it on dvn-build. Here is what is needed to replicate it:

• any user will see this bug (as opposed to previously suspected super user only)
• dataset has one or more ingested tabular data file
• dataset has guestbook with one or more custom, multiple choice question
• dataverse installation setup with Explore btn displayed**

(**See latest comment from me on 8/17 below...)

Also replicated this locally on the develop branch. Unfortunately the Glassfish server logs are clean when loading a dataset with a broken guestbook popup in the UI. There was an error in console of the browser element inspector however.

[Error] TypeError: undefined is not an object (evaluating 'd.left')
	(anonymous function) (primefaces.js.xhtml:23:10214)
	dispatch (jquery.js.xhtml:25:41043)
	handle (jquery.js.xhtml:25:37187)

[djbrooke]

Thanks @mheppler for the detailed investigation. @sekmiller is going to take a closer look (timebox 30 minutes or an hour) and bring it back to the team for estimation.

[sekmiller]

The guestbook popup is contained in file-download-popup-fragment.xhtml which is included in both dataset.xhtml and file.xhtml. The fragment has some complicated render logic as it decides whether to display Terms of Use/Access, asterisks for required guestbook responses, test box or dropdown list of responses for custom questions and error messages when required responses are left blank.
If the line (136) which adds select items for the custom question from down list is removed the broken dataset/file page issue goes away - but, of course that breaks the popup.

Seems pretty complicated to fix - it could be a timing issue where pre-populating the default response could wait until you actually need the pop-up (when the user presses the download/explore button) or something in the renders. I didn't see a simple fix with respect to changing the include.

[pdurbin]

For the record, line 136 is <f:selectItems value="#{customQuestionResponse.responseSelectItems}" />: https://github.com/IQSS/dataverse/blob/v4.9.1/src/main/webapp/file-download-popup-fragment.xhtml#L136

[mheppler]

Anything we learn about optimizing the popups should be added to for further code refactoring Dataset Publish/Submit for Review - Optimize Button/Popup Code #1664.

[mheppler]

While trying to replication this bug on my new installation of Dataverse, I did not see a broken guestbook popup as I had previously on my localhost, with the criteria outlined in my original comment above. It wasn't until I had set up TwoRavens and the Explore btn displayed for the guestbook popup to appear broken on my dataset pg. This is a great lead and hope to have this diagnosed quickly.