Some datasets showing up as links after manually changing "root" dataverse - remove hard coded value of 1

[scolapasta]

Reported by Sherry Lake from UVA:

After changing which dataverse was the "root" (by giving the original root a parent, and removing the parent from another dataverse), some datasets are improperly showing up as linked.

From the Google group:
https://groups.google.com/forum/?hl=en#!topic/dataverse-community/x042DsIk3-I

[scolapasta]

I looked in the code a bit and there is a line where the root dataverse is hard coded to id of 1.
In SearchIncludeFragment.java, line 1236 (additional lines provided for context):

// determine which of the objects are linked:

    if (!this.isRootDv()) {
        // (nothing is "linked" if it's the root DV!)
        Set<Long> dvObjectParentIds = new HashSet<>();
        for (SolrSearchResult result : searchResultsList) {
            if (dataverse.getId().equals(result.getParentIdAsLong())) {
                // definitely NOT linked:
                result.setIsInTree(true);
            } else if (result.getParentIdAsLong() == 1L) {
                // the object's parent is the root Dv; and the current 
                // Dv is NOT root... definitely linked:
                result.setIsInTree(false);
            } else {
                dvObjectParentIds.add(result.getParentIdAsLong());
            }
        }
        ...

[scolapasta]

Please note:
This may not be the exact cause of Sherry's issue (since the dataset's parent in question is not the former root), but this bug could still be indirectly causing the problem.

It would still be good to fix this and see the resultant effect it has on Sherry's test setup.

[scolapasta]

One last note and why I'm not convinced this will definitely fix Sherry's issue:
In her case the dataset that is incorrect has a parent id of 281. So even though the root is no longer id of 1 (it is id of 23313), this if statement would still return false.

(similarly there is a dataset that has a parent id of 13, in the same structure and that was does not show up as linked.)

In fact if it had been 1, then the previous statement would have caught it (since these results are being shown from the grandparent, which is the former root and does have id of 1) and so isInTree would be set to true)