datasetversion_id not being written to guestbookresponse on initial dataset page open/refresh when 'multi file' Download button clicked

[mdmADA]

tested on v 4.13 but applies to earlier versions:

Scenario:

1. Open a dataset page (choose one with open files just to make process quicker)
2. Choose any number of files
3. Click the 'multi-file' Download button above the file panel
4. Files download
5. The datasetversion_id value is NOT written to guestbookresponse

Repeat as many times as desired - same result

6. Click one of the individual file 'Download' buttons.

7. File downloads

8. The datasetversion_id IS written to guestbookresponse

9. Choose several files and use the 'multi-file' Download button

10. Files download

11. The datasetversion_id IS written to guestbookresponse

Now refresh the dataset page. The scenario starts at 1 again.

So it seems that the datasetversion_id is only set, and therefore written to guestbookresponse, in the DataversePage.java on the Individual download click.

Until one of the individual download buttons is clicked, then, the dasetversion_id is not set and so will not be written to the guestbookresponse table.

[pdurbin]

@mdmADA thanks for the bug report. I assume it's a bug. What is the bad outcome? Inaccurate download counts, I guess?

Do you think you can still reproduce this? Does the same thing happen via API? Are you still interested in this?

Sorry for all the questions. I'm really just thinking out loud. 😄

[qqmyers]

FWIW: I've seen this in the db at QDR and hadn't discovered the cause. I don't know if it is still current though or just historical.

In general, I think knowing which version downloads came from would be somewhat valuable, although the fileid should be enough to know what content users actually got.

In any case, it's in my backlog of things to look into at QDR so having this issue resurface is helpful. If anyone investigates further, please report it here.

[cmbz]

To focus on the most important features and bugs, we are closing issues created before 2020 (version 5.0) that are not new feature requests with the label 'Type: Feature'.

If you created this issue and you feel the team should revisit this decision, please reopen the issue and leave a comment.