broken kebab on file listing page when dataset out of compliance with new (5.11) terms policy

[qqmyers]

What steps does it take to reproduce the issue? Publish a dataset with files, try to use the kebob menu to restrict the file. The display looks like

and clicking the vertical ... kebab (note there's no down arrow after it) gives:

If I edit some metadata so that a draft version exists, the menus change to have a carat after them:

and it works as normal.

Which version of Dataverse are you using?
develop branch - doesn't seem to occur on 5.10.1

[mreekie]

Jim came accross this while using the software.
This was working previously.
Small

[pdurbin]

@qqmyers I'm on ba0183d (develop) and having trouble reproducing this. My kebabs don't seem to be missing the arrows and I get the normal popup when I go to restrict a file (screenshots below). Any more tips on how to reproduce this?

[qqmyers]

https://demo.dataverse.org/dataset.xhtml?persistentId=doi:10.70122/FK2/CRN2AW shows this issue for me. Not sure if there is something else about it, or develop has had changes that fix it already?

[pdurbin]

Hmm, that "quick test" dataset you also mentioned in #8845 and it doesn't show any versions?!?

Very strange. Maybe you and I can do a quick call to try to reproduce this. I can't reproduce it on demo either.

[qqmyers]

Hmm - I see

[qqmyers]

Ah - the issue is with published datasets that don't have filerequestaccess==true or termsofaccess set. You can no longer produce these, but existing published datasets would have this. (I was able to recreate this by manually setting the filerequestaccess='f' after publication (at QDR which was up-to-date w.r.t. develop as of last week)).

[pdurbin]

I'm able to reproduce this now. I had missed the step or restricting a file. Here are the steps:

• create a dataset
• upload at least two files
• restrict one of the files (accept the defaults, which is "allow access request" check and nothing written in terms.
• publish
• Set fileaccessrequest to false. I only have one dataset so I ran update termsofuseandaccess set fileaccessrequest = false;
• As a sanity check, run scripts/issues/8191/datasets_without_toa_or_request_access from the 5.11 release notes to see that this is now a dataset that's out of compliance. It has no terms and it doesn't allow access requests.
• Refresh the dataset page. You should see the strange kebab with no dropdown (screenshot below).
• Try clicking the strange kebab on either file (the restricted one or the non-restricted one). The "This file has already been deleted..." message will appear the moment you click the kebab (screenshot below). Basically, no operations are allowed, not just restrict. Note also that the "Edit Files" button is disabled.

I will say that the "out of compliance" message is prominently featured at the top ("Info – Datasets with restricted files are required to have Request Access enabled or Terms of Access to help people access the data. Please edit the dataset to confirm Request Access or provide Terms of Access to be in compliance with the policy."). So if anyone complains about this problem, it's easy enough to ask them to check for this message. Then, to fix the dataset, they can take the following steps:

• Click on Terms
• Click Edit Terms Requirements
• Note that "Enable access request" is already checked. (Dataverse is nudging them in this direction, by design.) This is a sufficient fix. Or they can fill in "Terms of Access for Restricted Files".
• Save Changes on the Terms tab.
• Note that the kebab is fixed and works like normal.
• In short, the yellow message at the top already tells the user how to fix the dataset.

weird kebab with no dropdown (note also yellow warning at top)

strange message when you click any weird kebab in the list of files

[pdurbin]

I'd also like to note that on the file landing page the behavior is similar but not quite the same. Instead of a kebab, there is an "Edit File" button but it is disabled. Since you cannot click this button, there is no "Edit File" popup error like we see on the dataset page (screenshot below). As with the dataset page, the instructions on how to fix the dataset are in yellow at the top.

[pdurbin]

We just discussed this issue in standup.

In short, the file landing page is working the way we want. The "Edit File" dropdown is disabled when the dataset is non-compliant.

The task is to apply the same logic to the dataset page. Don't let files be edited.