CRITICAL: Pressing Enter in Group Members assignment windows deletes the whole group

[philippconzett]

What steps does it take to reproduce the issue?

1. As an admin/curator in a TEST environment, click Edit > Groups > Create Group, and create a new user group for testing this issue.
2. Look up and add a user to the newly created test group, so that the user name displays in the Group Members field:

3. With the cursor placed to the right to the added user name, press Enter.

• When does this issue occur?
  See above.

• Which page(s) does it occurs on?
  On the Group edit page, e.g.
  https://demo.dataverse.org/manage-groups.xhtml?dataverseId=XX

• What happens?
  The group is deleted, and the following confirmation message appears on screen:

• To whom does it occur (all users, curators, superusers)?
  To everyone have the rights to add users to an existing user group.

• What did you expect to happen?
  Not sure. I guess many curators would expect the added user to be saved, thus they want to use Enter as a shortcut for scrolling to the bottom of the page and click Save Changes.

Which version of Dataverse are you using?
The behavior was tested on version v.5.6 (test.dataverse.no) and version v.5.11 (demo.dataverse.org).

Any related open or closed issues to this bug report?
None to my knowledge.

Screenshots:
See above.

[sekmiller]

@philippconzett it seems to be browser-related. It works as expected in Safari - ENTER adds the group/user. In Chrome I see the "Success- Group has been deleted" - at least when I add a user on Group Create. Will try on Group Edit next.

[sekmiller]

In Chrome the delete also happens on update group - add users.

[philippconzett]

Thanks, @sekmiller. I just tested this on Microsoft Edge also: On update group, the whole group is deleted when pressing Enter.

[philippconzett]

The same behavior also in Firefox.

[poikilotherm]

Is there a particular reason why there is no p:defaultCommand in our forms to make pressing enter key bound to an explicit behaviour (button)?

https://www.primefaces.org/showcase/ui/misc/defaultcommand/multiple.xhtml

HTML 5 specs says the default button is the one contained first in the tree. https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#implicit-submission The "delete" button is in a "higher" level of the DOM tree than our "submit" buttons, but they come before the delete buttons within the XHTML code. This might be a problem - not sure which is counting more as "comes first" in this case.

We could at least make the onclick modal also appear when pressing enter, so there is at least a dialogue that prevents the deletion.

[poikilotherm]

Oh wait - the add users thingies coming before the hidden p:commandButton for the deletion are p:commandLink, which is not bound to a default action. The p:commandButton to save the group is definitely coming after the delete buttons. The buttons for deletion are only hidden with the modal, but not disabled. So maybe the "bug" is that we have invisible buttons which are first in tree order and there is nothing stopping us from triggering them via keypress (unlike mouseclicks).

To make sure we are talking about the same - these are the delete buttons:

dataverse/src/main/webapp/manage-groups.xhtml

Lines 94 to 97 in b88f0df

	<div class="button-block">
	<p:commandButton styleClass="btn btn-default" value="#{bundle.continue}" onclick="PF('deleteConfirmation').hide()" action="#{manageGroupsPage.deleteGroup()}" update="manageGroupsForm,messagePanel"/>
	<p:commandButton styleClass="btn btn-link" value="#{bundle.cancel}" onclick="PF('deleteConfirmation').hide()"/>
	</div>

These are the save buttons:

dataverse/src/main/webapp/manage-groups.xhtml

Lines 168 to 177 in b88f0df

	<div class="button-block">
	<p:commandButton id="saveGroup" styleClass="btn btn-default"
	actionListener="#{manageGroupsPage.saveExplicitGroup}"
	value="#{bundle.saveChanges}"
	update="manageGroupsForm,messagePanel">
	</p:commandButton>
	<button class="btn btn-link" onclick="PF('viewGroup').hide()" type="button">
	#{bundle.cancel}
	</button>
	</div>

[sekmiller]

When I was working on this last week I tried only having the confirm delete popup render after the delete button was pressed. That fixed the "delete group on enter" problem, but the delete popup would appear and then disappear when the delete button was pressed. I will try to narrow the render around the "confirm delete" button instead of the popup itself.