Terms of Access for Restricted Files should not be displayed if there are no more restricted files.

[lmaylein]

For a dataset that previously had restricted files, we wanted to remove the restriction because the preconditions for this no longer exists. To be able to edit the record with v5.11 at all (disabled edit button with warning "Info – Datasets with restricted files are required to have Request Access enabled or Terms of Access to help people access the data. Please edit the dataset to confirm Request Access or provide Terms of Access to be in compliance with the policy."), we first had to enter Terms of Access for Restricted Files. Unfortunately, after the restrictions were removed from all files, we could no longer edit the terms (because this option was disabled now). This leads to a somewhat unattractive display.

How do we get rid of this again?

[sekmiller]

@lmaylein there is already an issue for this at #8832. We have a fix for it that will be part of the next release. The workaround currently is to restrict one of the files in the dataset, then edit the terms, then unrestrict the file. Sorry about the inconvenience.

[sekmiller]

Actually, hiding the terms when there are no restricted files is a different issue from what is addressed in 8832, so we should keep this open for the requested UI change - but again the workaround would be to briefly restrict a file and perform the edit on the terms.

[lmaylein]

Thanks. I thought we tried this workaround and it didn't work. But it seems to work after all.

[jggautier]

@lmaylein and @sekmiller. Should this issue really be closed? Will the requested UI change be included in #8832 after all?

[lmaylein]

Would be nice if it could not come to the case that it says:

There are 0 restricted files in this dataset.
Terms of Access for Restricted Files: ...

I don't know whether this can be included in #8832.

[sekmiller]

I didn't put it in 8832, but that hasn't been merged yet so I will endeavor to sneak it in.

[sekmiller]

@lmaylein, @jggautier It was a very small change so I included it in 8832 which is in QA.