flaky test: DownloadFilesIT.downloadAllFilesRestricted

[pdurbin]

@landreev and I have been discussing how DownloadFilesIT.downloadAllFilesRestricted has been flaky lately: https://iqss.slack.com/archives/C03R1E7T4KA/p1670439958671239

That is, it fails periodically with no known rhyme or reason. We should fix it.

Some places where we saw it fail:

• after feat(upload): make upload file storage path configurable #6656 #8983 was merged: https://jenkins.dataverse.org/job/IQSS-dataverse-develop/1209/consoleFull (
• 8092 timestamp of data access request #9257 (run 2 on Jenkins)

[qqmyers]

FWIW: The failure at

dataverse/src/test/java/edu/harvard/iq/dataverse/api/DownloadFilesIT.java

Lines 301 to 302 in ac1454b

	UtilIT.publishDatasetViaNativeApi(datasetPid, "major", apiToken)
	.then().assertThat().statusCode(OK.getStatusCode());

is at least consistent with a timing issue as there's a file upload right before it that could potentially not yet be complete.

[pdurbin]

I suppose this test is less flaky these days. We haven't heard about it lately. Closing.