Conversation
This comment has been minimized.
This comment has been minimized.
2f3d836 to
a087c0b
Compare
This comment has been minimized.
This comment has been minimized.
a087c0b to
b624206
Compare
This comment has been minimized.
This comment has been minimized.
b624206 to
0d1691a
Compare
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
5763b93 to
4f00cda
Compare
This comment has been minimized.
This comment has been minimized.
Developers can now test S3 locally by using the Dockerized development environment, which now includes both LocalStack and MinIO. See S3AccessIT which executes API (end to end) tests. In addition, a new integration test test class (not an API test, the new kind launched with `mvn verify`) has been added at S3AccessIOLocalstackIT. It uses Testcontainers to spin up Localstack for S3 testing and does not require Dataverse to be running. Note that the format of docker-compose-dev.yml had to change to allow for JVM options to be added. Finally, docs were improved for listing and setting stores via API.
4f00cda to
d4bab07
Compare
|
@jp-tosca I got things (mostly) working this morning; discovered what we believe is a bug in Dataverse in the process. Just wanted to document here that, while MinIO doesn't like repeated attempts to create a bucket via AWS CLI, re-running S3AccessIt tests manually doesn't return an error. Rocky Linux 8, LocalStack and MinIO are Dockerized. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This should have been part of 811d79a
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
I just tried [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0 |
|
I approved the PR on the Ansible side: Thank you, @donsizemore for all the hard work! 🚀 ❤️ 🎉 Once it's merged, we'll kick off another build to see if Jenkins starts passing. |
@pdurbin the Dataverse-Ansible branch is merged, so if you're comfortable with your own testing, Jenkins is ready. |
|
Thanks a lot @donsizemore !! |
|
@donsizemore thanks! I just kicked off a build: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-10044/17/ |

What this PR does / why we need it:
Developers can now test S3 locally by using the Dockerized development environment, which now includes both LocalStack and MinIO. See S3AccessIT which executes API (end to end) tests.
In addition, a new integration test test class
(not an API test, the new kind launched with
mvn verify) has been added at S3AccessIOLocalstackIT. It uses Testcontainers to spin up Localstack for S3 testing and does not require Dataverse to be running.TODO: Exercise direct upload, possibly borrowing code from DVUploader.Which issue(s) this PR closes:
Special notes for your reviewer:
Note that the format of docker-compose-dev.yml had to change to allow for JVM options to be added.
Suggestions on how to test this:
mvn -Pct clean package docker:run
mvn test -Dtest=S3AccessIT
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
Yes, included.
Additional documentation:
Tweaked various docs: