Deprecate rsync: remove from guides, mark code as deprecated#10620
Merged
stevenwinship merged 5 commits intodevelopfrom Jun 18, 2024
Merged
Deprecate rsync: remove from guides, mark code as deprecated#10620stevenwinship merged 5 commits intodevelopfrom
stevenwinship merged 5 commits intodevelopfrom
Conversation
pdurbin
added
Component: Code Infrastructure
This comment has been minimized.
This comment has been minimized.
landreev
reviewed
Jun 7, 2024
landreev
reviewed
Jun 7, 2024
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
landreev
approved these changes
Jun 11, 2024
Contributor
landreev
left a comment
landreev
left a comment
There was a problem hiding this comment.
Looks good!
Thanks for going to the trouble of going through the old code and deprecating things properly (as opposed to just dropping the text from the gudies).
Member
Author
|
I went ahead and remove rsync from our list of features at https://dataverse.org/software-features Here's how it looked before: 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Support for rsync has never been strong and no one is using it in production. At https://groups.google.com/g/dataverse-community/c/TMtVpYcqqFM/m/z0t4isZlHQAJ we asked the community if anyone minds if we deprecate it and there were no objections.
This pull request removes rsync and related content from the guides. It also marks various Java code and settings as deprecated but stops short of removing any code.
Which issue(s) this PR closes:
Special notes for your reviewer:
I went ahead and deprecated :PublicInstall which was mostly added for rsync. It does interact a bit with Swift as well but I adjusted the doc accordingly.Nevermind.Suggestions on how to test this:
Nothing to test. Just look at the diff and see if it makes sense.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
Yes, included.
Additional documentation:
You can preview the changes at https://dataverse-guide--10620.org.readthedocs.build/en/10620/