Added dataverse.db.parameters from long list of JVM options#10670
Added dataverse.db.parameters from long list of JVM options#10670pdurbin merged 3 commits intoIQSS:developfrom
Conversation
Addressing documentation issue IQSS#10669. Updated the config.rst file under doc/sphinx-guides/source/installation to add missing documentation about dataverse.db.parameters under JVM Options section
| | (installer sets to ``dvndb``) | ||
| * - dataverse.db.parameters | ||
| - Connection parameters, such as ``sslmode=require``. See `Postgres JDBC docs <https://jdbc.postgresql.org/documentation/head/connect.html>`_ | ||
| - Connection parameters, such as ``sslmode=require``. See `Postgres JDBC docs <https://jdbc.postgresql.org/documentation/head/connect.html>` |
There was a problem hiding this comment.
The _ suffix may not be removed here. In RestructuredText links need this char to be declared links, otherwise the backticks are interpreted as layouting directives. See also the preview generated at https://dataverse-guide--10670.org.readthedocs.build/en/10670/installation/config.html#basic-database-settings
|
Good job overall, just a few minor tweaks. Thank you very much @diptechexpo for this PR! As it is a docs only PR we can fast track it as usual once the review is completed and approved. |
Co-authored-by: Oliver Bertuch <poikilotherm@users.noreply.github.com>
Added back underscore(_) character to maintain the link.
diptechexpo
left a comment
diptechexpo
left a comment
There was a problem hiding this comment.
Incorporated review comments. Submitting for re-review.
poikilotherm
left a comment
poikilotherm
left a comment
There was a problem hiding this comment.
Looks good to me! Signing off, good to go!
|
@pdurbin assining to you, double checking this can be fast tracked. |
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
https://dataverse-guide--10670.org.readthedocs.build/en/10670/installation/config.html#dataverse-db-parameters looks great! Thanks for the pull request, @diptechexpo!
And thanks to @poikilotherm for noticing it was missing!
Merging!
3 participants
Addressing documentation issue #10669. Updated the config.rst file under doc/sphinx-guides/source/installation to add missing documentation about dataverse.db.parameters under JVM Options section
What this PR does / why we need it: Improve documentation
Which issue(s) this PR closes:
Special notes for your reviewer: None
Suggestions on how to test this: No code change. Review of the documentation change is required only.
Does this PR introduce a user interface change? If mockups are available, please link/include them here: No
Is there a release notes update needed for this change?: No
Additional documentation: None