Fixes unit test assertion in JsonParserTest#10999
Merged
ofahimIQSS merged 3 commits intodevelopfrom Nov 4, 2024
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
stevenwinship
approved these changes
Nov 4, 2024
pdurbin
approved these changes
Nov 4, 2024
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
API tests are passing: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-10999/3/testReport/
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
Contributor
|
Confirmed tests are now passing. Merging PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes unit test assertion in JsonParserTest
Which issue(s) this PR closes:
N/A
Special notes for your reviewer:
https://jenkins.dataverse.org/job/IQSS-dataverse-develop/1899/testReport/edu.harvard.iq.dataverse.util.json/JsonParserTest/parseDataverseDTO/ says
expected: <pi@example.edu,student@example.edu> but was: <pi@example.edu>It's failing here: https://github.com/IQSS/dataverse/actions/runs/11662305024/job/32468392175#step:4:9654
From #10925
Suggestions on how to test this:
Visual inspection and unit test run
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
No
Additional documentation:
None