IQSS/11174-ROR url not added in author affiliation

[qqmyers]

What this PR does / why we need it: Fixes a bug in the DataCite metadata/export.

Which issue(s) this PR closes:

• Closes DataCite export doesn't correctly write ROR for author affiliation #11174

Special notes for your reviewer:

Suggestions on how to test this:
Configure the ROR script for the author affiliation field (e.g. as on demo). Use a ROR URL for the author affiliation, publish, and verify that the DataCite xml exported has the ROR URL in the affiliationID attribute as in the example in the issue. (To test a dataset published with the prior code, you can just run the reexportDataset API call to see the DataCite xml get updated.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

[coveralls]

coverage: 22.751%. remained the same
when pulling 782188f on QualitativeDataRepository:IQSS/11174-Fix_authorAffiliation_DataCite_XML
into 69ebed2 on IQSS:develop.

[pdurbin]

At standup today I said I thought this PR would affect the tests I'm writing for but it seems not to be the case. It has no effect.

I'm creating an author like this:

.add(Json.createObjectBuilder()
        .add("authorName",
                Json.createObjectBuilder()
                        .add("value", "Simpson, Homer")
                        .add("typeClass", "primitive")
                        .add("multiple", false)
                        .add("typeName", "authorName")
        )
        .add("authorAffiliation",
                Json.createObjectBuilder()
                        .add("value", "https://ror.org/03vek6s52")
                        .add("typeClass", "primitive")
                        .add("multiple", false)
                        .add("typeName", "authorAffiliation")
        )
)

With or without this PR, I'm getting this as output from the "Datacite" exporter:

<affiliation affiliationIdentifier="https://ror.org/03vek6s52" schemeURI="https://ror.org" affiliationIdentifierScheme="ROR">https://ror.org/03vek6s52</affiliation>

I guess I'll go ahead and approve it.

I suspect it might need to be tested with a working :CVocConf config, which I'm not testing with.

[qqmyers]

Yep - good catch - the ROR URL is only converted to the org name if the ROR script has been configured so that the name has been cached.

[ofahimIQSS]

When I deploy this to internal - internal goes down and displays the payara page.

[qqmyers]

Internal has a problem with the Flyway 6.5.0.2 script having been changed (presumably different branches got deployed there). Not related to this PR per se.

[pdurbin]

I suspect it might need to be tested with a working :CVocConf config, which I'm not testing with.

For the record, I did testing with a working :CVocConf config. I left a TODO in the other PR:

• add ROR as an Author Identifier Type #11118

                    // Once https://github.com/IQSS/dataverse/pull/11175 is merged the equalTo below
                    // should be "https://ror.org/03vek6s52" instead of "Harvard University".
                    .body("resource.creators.creator[0].affiliation.@affiliationIdentifier", equalTo("Harvard University"));

[ofahimIQSS]

No issues found during testing of the PR.

The format here is incorrect as ror.org is appearing twice, but that should get addressed by #11118
schemeURI="https://ror.org">https://ror.org/https://ror.org/044hpwe09

[qqmyers]

FWIW: This PR is about the author affiliation field when a ROR is used there and when a ROR external vocab script is enabled for it. Use of a ROR for the author name (as shown in the image above) is not affected.