Openaire fix for multiple productionPlaces#11194
Merged
ofahimIQSS merged 9 commits intoIQSS:developfrom Feb 3, 2025
Merged
Conversation
Member
Made multiple in this PR: |
Contributor
Member
|
@jggautier yes, good catch. I left some comments on #9546. This PR fixes it so I added "closes #9546" to the description of this PR for the issue to get auto-closed on merge. |
pdurbin
reviewed
Jan 31, 2025
Co-authored-by: Philip Durbin <philipdurbin@gmail.com>
Contributor
Author
|
@pdurbin I have added two test functions and added the the release note snippet. So eventually we are ready for the merge? |
pdurbin
approved these changes
Feb 3, 2025
Member
pdurbin
left a comment
There was a problem hiding this comment.
Tests are passing: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-11194/5/testReport/
@ffritze thanks for the PR and the extra tests! I'm approving this.
Contributor
|
tests passed - merging PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Tests are written and adapted for this pull request. They are passing.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: