In ExportDataProvider, add directoryLabel (file path) to getDatasetFileDetails#11618
Merged
ofahimIQSS merged 5 commits intoIQSS:developfrom Aug 19, 2025
Merged
In ExportDataProvider, add directoryLabel (file path) to getDatasetFileDetails#11618ofahimIQSS merged 5 commits intoIQSS:developfrom
ofahimIQSS merged 5 commits intoIQSS:developfrom
Conversation
pdurbin
changed the title
ofahimIQSS
moved this from Ready for Triage
to Ready for Review ⏩
in IQSS Dataverse Project
stevenwinship
moved this from Ready for Review ⏩
to In Review 🔎
in IQSS Dataverse Project
| JsonArrayBuilder jab = Json.createArrayBuilder(); | ||
| for (FileMetadata fileMetadata : dv.getFileMetadatas()) { | ||
| // this is to be added in the end json... | ||
| fileMetadata.getDirectoryLabel(); |
Contributor
There was a problem hiding this comment.
This code does nothing. It can be removed
Contributor
Author
There was a problem hiding this comment.
i have overseen that, thanks for pointing out- i removed the lines
stevenwinship
approved these changes
Jul 15, 2025
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
pdurbin
reviewed
Jul 15, 2025
pdurbin
approved these changes
Jul 15, 2025
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
I improved the release note and added a "how to test" section. Approved. Thanks, @univiedev! ❤️
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
|
Hello! I see branch conflicts - can you please update? |
Conflicts: src/main/java/edu/harvard/iq/dataverse/util/json/JsonPrinter.java InternalExportProviderTest was throwing an NPE for getDatasetVersion() in the following line in JsonPrinter (added in 8a57fc8): .add("lastUpdateTime", format(fileMetadata.getDatasetVersion().getLastUpdateTime()));
Contributor
|
looks good from my end - merging PR. |
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR closes:
Special notes for your reviewer:
None.
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
Yes, included.
Additional documentation:
None.
Related discussion:
https://dataverse.zulipchat.com/#narrow/channel/375707-community/topic/Dataverse4ever/near/525536843