Review Datasets

[pdurbin]

What this PR does / why we need it:

Makes creation of review datasets possible.

Which issue(s) this PR closes:

• Closes Add "review" scholarly research object #11747
• Closes Design "Item Reviewed" metadata fields #12015
• Closes Allow control over which dataset types are available, per collection #12115
• Closes Dataset types should have a display name and a description #11887
• Closes investigate why the Dataset Type facet works in JSF but not the SPA #11758
• Closes 500 error when deleting dataset type by name #11833

Special notes for your reviewer:

• This is a decent entry point for the docs: https://dataverse-guide--11753.org.readthedocs.build/en/11753/user/dataset-management.html#review-datasets
• I'm aware that the displayName and description of a dataset type cannot be changed via API. A workaround is to use properties files. On a related note, perhaps these two classes should be refactored into a single class for updating dataset types?
  • https://github.com/IQSS/dataverse/blame/v6.9/src/main/java/edu/harvard/iq/dataverse/engine/command/impl/UpdateDatasetTypeLinksToMetadataBlocksCommand.java
  • https://github.com/IQSS/dataverse/blob/v6.9/src/main/java/edu/harvard/iq/dataverse/engine/command/impl/UpdateDatasetTypeAvailableLicensesCommand.java
• I'm aware that you can't unset allowedDatasetTypes from a collection. You can't set it back to null. I documented a workaround, which is to set it to "dataset". This will remove the connection between a dataset type and a collection to allow you to delete the dataset type.

Suggestions on how to test this:

• Do all the setup at https://dataverse-guide--11753.org.readthedocs.build/en/11753/admin/dataverses-datasets.html#review-datasets-setup
• Create a review dataset (via API)
• Test DataCite changes; confirm that DataCite received <resourceType resourceTypeGeneral="Other">Review</resourceType>
• Test data citation changes for the CSL format. The "type" can now be "dataset", "software", or "review".

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Yes, the facets under "Dataset Type" are changing from human readable and translatable ("Dataset" from getDisplayName) to machine-readable ("dataset" from getName). This is to fix #11758 and IQSS/dataverse-frontend#809

Before

After

Note that I'm aware that even after this fix, when you click any of the machine readable names, such as "software", the friendly name will appear above the search results like this:

I left a note in the xhtml about this. I don't think this is worth fixing on the JSF side. In the SPA, the values will consistently be the machine readable versions, such as "software" (lower case).

Is there a release notes update needed for this change?:

Included

[coveralls]

coverage: 24.395% (-0.02%) from 24.412%
when pulling 5165d20 on 11747-review-dataset-type
into fea7dcc on develop.

[jggautier]

Next Tuesday I'll add to this PR . properties files for the two metadata blocks

[jggautier]

I put the two properties files for the metadata blocks into this branch's src/main/java/propertyFiles folder

[github-actions]

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:11747-review-dataset-type

ghcr.io/gdcc/configbaker:11747-review-dataset-type

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.