Skip to content

IQSS/11909-Update netcdf library #11910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pdurbin merged 1 commit into from
Nov 5, 2025
Merged

IQSS/11909-Update netcdf library #11910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
<jhove.version>1.20.1</jhove.version>
<poi.version>5.4.0</poi.version>
<tika.version>3.2.2</tika.version>
<netcdf.version>5.5.3</netcdf.version>
<netcdf.version>5.9.1</netcdf.version>

<openapi.infoTitle>Dataverse API</openapi.infoTitle>
<openapi.infoVersion>${project.version}</openapi.infoVersion>
Expand Down
5 changes: 2 additions & 3 deletions src/main/java/edu/harvard/iq/dataverse/pidproviders/AbstractPidProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
import java.util.logging.Logger;

import org.apache.commons.lang3.RandomStringUtils;
import com.beust.jcommander.Strings;

public abstract class AbstractPidProvider implements PidProvider {

Expand Down Expand Up @@ -577,8 +576,8 @@ public JsonObject getProviderSpecification() {
providerSpecification.add("shoulder", shoulder);
providerSpecification.add("identifierGenerationStyle", identifierGenerationStyle);
providerSpecification.add("datafilePidFormat", datafilePidFormat);
providerSpecification.add("managedSet", Strings.join(",", managedSet.toArray()));
providerSpecification.add("excludedSet", Strings.join(",", excludedSet.toArray()));
providerSpecification.add("managedSet", String.join(",", managedSet));
providerSpecification.add("excludedSet", String.join(",", excludedSet));
return providerSpecification.build();
}

Copy link
Member

@pdurbin pdurbin Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jenkins is failing but I think it's unrelated to this PR. I just kicked off another run: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-11910/3/

Expand Down