Skip to content

Comments

refactor UpdateDatasetLicenseCommand to extend AbstractDatasetCommand<Dataset>#11958

Merged
scolapasta merged 6 commits intodevelopfrom
11771-fix-npe-in-update-licenses
Nov 20, 2025
Merged

refactor UpdateDatasetLicenseCommand to extend AbstractDatasetCommand<Dataset>#11958
scolapasta merged 6 commits intodevelopfrom
11771-fix-npe-in-update-licenses

Conversation

@stevenwinship
Copy link
Contributor

What this PR does / why we need it: NPE in async indexing after updating the license and calling update version. On Success was not passed the dataset.

Which issue(s) this PR closes:#11771

Special notes for your reviewer:

Suggestions on how to test this: call the api and check the dataverse log for the null pointer exception

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: release note is in original pr

Additional documentation:

@stevenwinship stevenwinship self-assigned this Nov 5, 2025
@github-actions github-actions bot added FY26 Sprint 5 FY26 Sprint 5 (2025-08-27 - 2025-09-10) FY26 Sprint 6 FY26 Sprint 6 (2025-09-10 - 2025-09-24) GREI Re-arch Issues related to the GREI Dataverse rearchitecture Original size: 20 Size: 20 A percentage of a sprint. 14 hours. SPA These changes are required for the Dataverse SPA SPA.Q3.2025.3 Dataset Page: Edit Terms Type: Feature a feature request labels Nov 5, 2025
@stevenwinship stevenwinship moved this to In Progress 💻 in IQSS Dataverse Project Nov 5, 2025
@stevenwinship stevenwinship added Size: 0.5 A percentage of a sprint. 0.35 hours and removed Size: 20 A percentage of a sprint. 14 hours. labels Nov 5, 2025
@coveralls
Copy link

coveralls commented Nov 5, 2025

Coverage Status

coverage: 23.802% (-0.001%) from 23.803%
when pulling 2a66575 on 11771-fix-npe-in-update-licenses
into b78060a on develop.

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@cmbz cmbz added the FY26 Sprint 10 FY26 Sprint 10 (2025-11-05 - 2025-11-19) label Nov 5, 2025
@stevenwinship stevenwinship removed their assignment Nov 6, 2025
@stevenwinship stevenwinship moved this from In Progress 💻 to Ready for Review ⏩ in IQSS Dataverse Project Nov 6, 2025
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-11958/5/testReport/ passed. I assume the current run will pass as well.

@github-project-automation github-project-automation bot moved this from Ready for Review ⏩ to Ready for QA ⏩ in IQSS Dataverse Project Nov 13, 2025
@github-actions
Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:11771-fix-npe-in-update-licenses
ghcr.io/gdcc/configbaker:11771-fix-npe-in-update-licenses

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@scolapasta scolapasta self-assigned this Nov 20, 2025
@scolapasta scolapasta moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Nov 20, 2025
@scolapasta scolapasta merged commit 5c8c9d7 into develop Nov 20, 2025
20 checks passed
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Nov 20, 2025
@pdurbin pdurbin added this to the 6.9 milestone Nov 21, 2025
@cmbz cmbz added the FY26 Sprint 11 FY26 Sprint 11 (2025-11-20 - 2025-12-03) label Nov 22, 2025
@pdurbin pdurbin moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 5 FY26 Sprint 5 (2025-08-27 - 2025-09-10) FY26 Sprint 6 FY26 Sprint 6 (2025-09-10 - 2025-09-24) FY26 Sprint 10 FY26 Sprint 10 (2025-11-05 - 2025-11-19) FY26 Sprint 11 FY26 Sprint 11 (2025-11-20 - 2025-12-03) GREI Re-arch Issues related to the GREI Dataverse rearchitecture Original size: 20 Size: 0.5 A percentage of a sprint. 0.35 hours SPA.Q3.2025.3 Dataset Page: Edit Terms SPA These changes are required for the Dataverse SPA Type: Feature a feature request

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

API: Set configuring licenses and custom terms for a dataset

5 participants