refactor UpdateDatasetLicenseCommand to extend AbstractDatasetCommand<Dataset>#11958
Merged
scolapasta merged 6 commits intodevelopfrom Nov 20, 2025
Merged
refactor UpdateDatasetLicenseCommand to extend AbstractDatasetCommand<Dataset>#11958scolapasta merged 6 commits intodevelopfrom
scolapasta merged 6 commits intodevelopfrom
Conversation
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
pdurbin
approved these changes
Nov 13, 2025
Member
pdurbin
left a comment
There was a problem hiding this comment.
Approved. https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-11958/5/testReport/ passed. I assume the current run will pass as well.
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: NPE in async indexing after updating the license and calling update version. On Success was not passed the dataset.
Which issue(s) this PR closes:#11771
Special notes for your reviewer:
Suggestions on how to test this: call the api and check the dataverse log for the null pointer exception
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: release note is in original pr
Additional documentation: