Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements API endpoints to set and remove the default template for a dataverse collection, addressing issue #11914.
Key Changes:
- Added
POST /api/dataverses/{id}/templates/default/{templateId}endpoint to set a default template - Added
DELETE /api/dataverses/{id}/templates/defaultendpoint to remove the default template - Added test coverage for the set default template endpoint with permission checks
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
src/main/java/edu/harvard/iq/dataverse/api/Dataverses.java |
Implements two new endpoints for setting and removing default templates |
src/test/java/edu/harvard/iq/dataverse/api/UtilIT.java |
Adds helper methods setDefaultTemplate() and removeDefaultTemplate() for testing |
src/test/java/edu/harvard/iq/dataverse/api/DataversesIT.java |
Updates testCreateAndGetTemplates() to test setting default template with authorization checks |
doc/release-notes/11914-set-template-default-api.md |
Documents the new endpoints and their functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…or removing default template
…DefaultTemplateCommand.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…oveDefaultTemplateCommand.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
Added the doc; turning it back over to you. |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: