Skip to content

Fix Role Assignement History Panel showing when feature is off #12052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sekmiller merged 1 commit into from
Dec 18, 2025
Merged

Fix Role Assignement History Panel showing when feature is off #12052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/webapp/permissions-manage-files.xhtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@
</div>
<!-- Role Assignment History Panel -->
<o:importConstants type="edu.harvard.iq.dataverse.settings.FeatureFlags" />
<div class="panel panel-default" rendered="#{FeatureFlags.ROLE_ASSIGNMENT_HISTORY.enabled()}">
<div class="panel panel-default" jsf:rendered="#{FeatureFlags.ROLE_ASSIGNMENT_HISTORY.enabled()}">
<div data-toggle="collapse" data-target="#panelCollapseHistory" class="panel-heading text-info">
#{bundle['dataverse.permissions.history']} <span class="glyphicon glyphicon-chevron-down" /> <span class="text-muted small pull-right">#{bundle['dataverse.permissions.history.description']}</span>
</div>
Expand Down
3 changes: 2 additions & 1 deletion src/main/webapp/permissions-manage.xhtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:p="http://primefaces.org/ui"
xmlns:c="http://java.sun.com/jsp/jstl/core"
xmlns:jsf="http://xmlns.jcp.org/jsf"
xmlns:o="http://omnifaces.org/ui"
xmlns:iqbs="http://xmlns.jcp.org/jsf/composite/iqbs">

Expand Down Expand Up @@ -198,7 +199,7 @@
</div>
<!-- Role Assignment History Panel -->
<o:importConstants type="edu.harvard.iq.dataverse.settings.FeatureFlags" />
<div class="panel panel-default" rendered="#{FeatureFlags.ROLE_ASSIGNMENT_HISTORY.enabled()}">
<div class="panel panel-default" jsf:rendered="#{FeatureFlags.ROLE_ASSIGNMENT_HISTORY.enabled()}">
<div data-toggle="collapse" data-target="#panelCollapseHistory" class="panel-heading text-info">
#{bundle['dataverse.permissions.history']} <span class="glyphicon glyphicon-chevron-down" /> <span class="text-muted small pull-right">#{bundle['dataverse.permissions.history.description']}</span>
</div>
Expand Down