Test Internationalization of dataverseuser.xhtml#20
Closed
Jian881219 wants to merge 13 commits intomasterfrom
unknown repository
Closed
Test Internationalization of dataverseuser.xhtml#20Jian881219 wants to merge 13 commits intomasterfrom unknown repository
Jian881219 wants to merge 13 commits intomasterfrom
unknown repository
Conversation
Member
|
I pulled the branch according to the command line instructions... ... and I'm poking around a bit. The first thing I noticed is that I'm seeing I was still able to create an account and validation seems to be working. |
Author
|
I had changed my code later and commited it by Netbeans , but i didn't realize that the dataverseuser.xhtml failed to commit . I will update it next. Are there any other problems about our internationalize ? Can we proceed to the next step work ? |
pdurbin
pushed a commit
to pdurbin/dataverse
that referenced
this pull request
Oct 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Including msgs from *.java and bean validator.
I think , it's better by using "{0},was created in {1}.Don't forget to publish it! ", because the grammatical structure of different language is different.
The error message is repeating when username is already taken. Maybe we can use "@Form" instead of "@ALL" to avoid it