Skip to content

Comments

3635 style guide#3737

Merged
kcondon merged 19 commits intodevelopfrom
3635-style-guide
Apr 4, 2017
Merged

3635 style guide#3737
kcondon merged 19 commits intodevelopfrom
3635-style-guide

Conversation

@mheppler
Copy link
Contributor

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and while we'd love it if you write unit tests, but we're happy to review your pull request even if you don't write tests or complete all of the checklist items below! Thanks for making a pull request!

Related Issues

Pull Request Checklist

mheppler and others added 15 commits March 17, 2017 12:14
Added an introductory sentence before the table of contents to explain the purpose and intended usage of the style guide.
Started editing this page, got through the Foundations and Grid Layouts sections. If any of the elaborations I made were inaccurate, let me know! I'm planning on getting further into this doc tomorrow.
-Reviewed full document for typos, grammar, and clarity
-Changed Color Palette subsection titles to include the word "color" for easy skim-ability.
-Changed Icons subsection titles to include the word "icons" for easy skim-ability
-Changed order of sections for "narrative" flow, moving from basics to text to colors to icons to images.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 9.717% when pulling 41a4505 on 3635-style-guide into 1cf0341 on develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 9.713% when pulling 0c4d1b3 on 3635-style-guide into 1cf0341 on develop.

@pdurbin pdurbin self-requested a review March 31, 2017 16:05
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Merge it.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 9.731% when pulling 21a83a4 on 3635-style-guide into 1cf0341 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 9.731% when pulling 7088dcd on 3635-style-guide into 17782e4 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 9.731% when pulling d720c86 on 3635-style-guide into 17782e4 on develop.

@kcondon kcondon merged commit 58687a8 into develop Apr 4, 2017
@kcondon kcondon deleted the 3635-style-guide branch April 4, 2017 22:11
@pdurbin pdurbin added this to the 4.6.2 - Tabular Mapping milestone May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants