Skip to content

Comments

save files permanently in command rather than JSF page #3866#3868

Merged
kcondon merged 1 commit intodevelopfrom
3866-add-files-on-create-fail
May 31, 2017
Merged

save files permanently in command rather than JSF page #3866#3868
kcondon merged 1 commit intodevelopfrom
3866-add-files-on-create-fail

Conversation

@pdurbin
Copy link
Member

@pdurbin pdurbin commented May 31, 2017

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!

Related Issues

Pull Request Checklist

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0002%) to 10.042% when pulling dac6f3f on 3866-add-files-on-create-fail into cb0e38f on develop.

@raprasad
Copy link
Contributor

raprasad commented May 31, 2017

Fix is working for me. Also reviewed code/logic with @pdurbin

@kcondon kcondon merged commit 20d85b3 into develop May 31, 2017
@kcondon kcondon deleted the 3866-add-files-on-create-fail branch May 31, 2017 20:20
@pdurbin pdurbin added this to the 4.6.2 - Tabular Mapping milestone Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants