1551-Make Use of RedirectPage Logic#3910
Closed
sudofly-ai wants to merge 2 commits intoIQSS:developfrom
sudofly-ai:feature/1551-Shibboleth-login-redirect
Closed
1551-Make Use of RedirectPage Logic#3910sudofly-ai wants to merge 2 commits intoIQSS:developfrom sudofly-ai:feature/1551-Shibboleth-login-redirect
sudofly-ai wants to merge 2 commits intoIQSS:developfrom
sudofly-ai:feature/1551-Shibboleth-login-redirect
Conversation
|
|
||
| function urlParam(name) { | ||
| var results = new RegExp('[\?&]' + name + '=([^&#]*)').exec(window.location.href); | ||
| return results[1] || 0; |
Contributor
There was a problem hiding this comment.
What does the results[1] || 0; line do? It needs a comment probably
Author
There was a problem hiding this comment.
@oscardssmith sure, you can include this comment for the function:
Returns the value for the specified parameter, or 0 if the parameter is not found in the url string
oscardssmith
approved these changes
Jun 19, 2017
scolapasta
approved these changes
Jun 19, 2017
Member
|
Closing in favor of #3929. The branch was behind develop. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Pull Request Checklist