4634 move english strings to property file

[JayanthyChengan]

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!

Related Issues

• connects to #ISSUE_NUMBER: ISSUE_TITLE

Pull Request Checklist

• Unit tests completed
• Integration tests: None
• Deployment requirements, SQL updates, Solr updates, etc.: None
• Documentation completed
• Merged latest from "develop" branch and resolved conflicts

---

Update by @pdurbin connects to #4634

[coveralls]

Coverage remained the same at 13.371% when pulling aecda15 on scholarsportal:4634-move-English-strings-to-property-file into 1b24063 on IQSS:develop.

[pdurbin]

I believe all of these changes make sense.

[mheppler]

Thank you for tackling these, @JayanthyChengan. I suggest that it is OK to move this back to QA. I just wanted a chance to look into each of the XHTML files to see if there was any other text snippet stragglers in there. While I found a few instances in other files, I won't suggest they need to be addressed in this PR.

Here is a run down of what I found:

/src/main/webapp/dataset-versions.xhtml [Line 27, 42] -- javascript, display:none
/src/main/webapp/dataset.xhtml [Line 471] -- display:none
/src/main/webapp/dataverse_header.xhtml [Line 20] -- toggle nav
/src/main/webapp/dataverse_template.xhtml [Line 56] -- default body

/src/main/webapp/editFilesFragment.xhtml [Lines 402-542] -- Select Language Encoding...

/src/main/webapp/editdatafiles.xhtml [Line 70] -- KB
/src/main/webapp/file-versions.xhtml [Line 27, 41] -- javascript, display:none

/src/main/webapp/harvestclients.xhtml [Line 78] -- Filter
/src/main/webapp/harvestsets.xhtml [Line 104] -- Filter

/src/main/webapp/loginpage.xhtml [Line 162, 197] -- shib:no javascript, ORCID
/src/main/webapp/permissions-manage-files.xhtml [Line 53, 99] -- requests, users/groups
/src/main/webapp/roles-edit.xhtml [Line 74] -- cancel

/src/main/webapp/superuser.xhtml [Line 23, 26] -- index all, check status

Some of those might not need to go to the bundle. ("KB" might be kosker internationally...? "Default body" shouldn't ever get displayed in the UI...??)

The one file on the list that did give me pause was editFilesFragment.xhtml, because it is already included in this PR. @scolapasta maybe you have some feedback on whether the "Select Language Encoding" dropdown options ("Western (ISO-8859-1)", "Central European (MacCE)", et al) could be moved to the bundle. If you agree that all of these are OK to save for the next phase of improvements, then please pass this PR along to QA! Thanks!

[scolapasta]

Yes, I think those (the names, not the encodings themselves) should be moved to the bundle. But that can wait until next phase. Moving to QA.