New API endpoints for TRSA (Trusted Remote Storage Agent) of ImPACT project: stage 1#4750
Closed
akio-sone wants to merge 67 commits intoIQSS:developfrom
Closed
New API endpoints for TRSA (Trusted Remote Storage Agent) of ImPACT project: stage 1#4750akio-sone wants to merge 67 commits intoIQSS:developfrom
akio-sone wants to merge 67 commits intoIQSS:developfrom
Conversation
dataFile => dataTable contin => CONTINUOUS, etc.
akio-sone
changed the title
Member
|
@akio-sone head ups that there are merge conflicts in pom.xml |
Contributor
|
Closing this PR, updated PR incoming. Will link here when available. |
|
@scolapasta Do you know if there was ever an updated PR for this issue? #5213 |
Contributor
|
I am not immediately aware - maybe @Asone can recall? |
|
@scolapasta : I guess you made a mistake, you probably meant @akio-sone ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is the first stage of adding new Dataverse Native API endpoints for the TRSA (Trusted Remote Storage Agent) of ImPACT (Infrastructure for Privacy-Assured CompuTations: http://cyberimpact.us/).
More specifically, These new API endpoints are expected to handle the submission of (1) a locally ingested new dataset or (2) a locally ingest ingest new data file (s) as a JSON file without invoking the host Dataverse's ingest process. By design, this submission request from a TRSA does not or cannot upload locally ingested data files to the host Dataverse due to security restrictions on them. Also, these new API endpoints deal with up to Datavariable-level metadata in JSON format whose functionality is missing from the current set of Native API endpoints.
This pull requests implements the former API endpoint (1: adding a new dataset) and the latter one (2: adding new data files) is currently a stub. The former (BatchImport#postImportWoI method) is a variant of BatchImport#postImport method and the latter (Datasets#addFileMetadataToDataset method) is based on Datasets#addFileToDataset method. These two API endpoints are backed by newly added methods to JsonParser/JsonPrinter classes for Datavariable-level metadata. The implementation of the latter API endpoint would be covered by the next pull request.
New Contributors
Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!
Related Issues
Pull Request Checklist