Conversation
| } | ||
| sitemapPathAndFile = sitemapPath + File.separator + SITEMAP_FILENAME; | ||
|
|
||
| DocumentBuilderFactory documentBuilderFactory = DocumentBuilderFactory.newInstance(); |
Contributor
There was a problem hiding this comment.
It seems like this generation could benefit from schema validation via DocumentBuilderFactory.setSchema(schema) ?
|
|
||
| Exception notValidAgainstSchemaException = null; | ||
| try { | ||
| assertTrue(XmlValidator.validateXmlSchema("/tmp/sitemap.xml", new URL("https://www.sitemaps.org/schemas/sitemap/0.9/sitemap.xsd"))); |
Contributor
There was a problem hiding this comment.
Ahh I see we validate here. Do we know if-when google updates there schema whether they will support old versions? I could see value in general of validating against the schema on each run if it lets us know more quickly that google won't stop indexing us.
matthew-a-dunlap
approved these changes
Oct 1, 2018
Contributor
matthew-a-dunlap
left a comment
matthew-a-dunlap
left a comment
There was a problem hiding this comment.
After talking with Phil I'm fine with the code as it stands
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connects to #4261