Conversation
src/main/java/Bundle.properties
Outdated
| admin.api.migrateHDL.failure=Failed to migrate Dataset Handle id: {0} | ||
| admin.api.migrateHDL.failureWithException=Failed to migrate Dataset Handle id: {0} Unexpected exception: {1} | ||
|
|
||
| #Roles |
There was a problem hiding this comment.
These are actually permissions; let's rename them that way.
There was a problem hiding this comment.
I'm not convinced we want to translate these - though yes to their descriptions. (it's probably ok to translate, it's just these are "reserved words" in the code.
There was a problem hiding this comment.
I will discuss with @amberleahey and @mhvezina to clarify whether those "reserved words" from line number 2074 to 2086 to be translated.
There was a problem hiding this comment.
Since those strings are displayed in the user interface, I would like to have a way to be able to translate them.
There was a problem hiding this comment.
I too agree we should translate these: they may be role types that are stored but they are readable/meaningful in the user interface. This is working as per the updated pull request
src/main/java/Bundle.properties
Outdated
| roles.DeleteDataverse=DeleteDataverse | ||
| roles.DeleteDatasetDraft=DeleteDatasetDraft | ||
|
|
||
| permission.AddDataverse=Add a dataverse within another dataverse |
There was a problem hiding this comment.
and this is their descriptions.
| if (alias != null ) | ||
| { | ||
| String key = "role." + alias.toLowerCase() +".name"; | ||
| return BundleUtil.getStringFromPropertyFile(key,"BuiltInRoles" ); |
There was a problem hiding this comment.
How will this work with Custom roles?
There was a problem hiding this comment.
@scolapasta: I didn't handle custom role in this pull request. Is custom role also comes from JSON files? Haven't investigated on the logic behind custom role. Please add some information related to custom roles, can we handle it in separate issue?
There was a problem hiding this comment.
After testing the fix @JayanthyChengan made today, custom roles in our local dvdev is now working as expected, can create/edit/apply custom roles.
There was a problem hiding this comment.
@scolapasta: the code got outdated after I committed new code( which will handle custom roles). Hope I understood correctly and updated the code accordingly. Please review
…JSON # Conflicts: # src/main/java/Bundle.properties
|
renamed the property in bundle.properties as @scolapasta requested. |
|
Thanks @JayanthyChengan. Is this ready for code review? |
|
Yes, it's ready for code review |
8 participants
connects to #5126