Skip to content

Comments

Fix #5225 - Crendential store bundle key instead of value#5244

Merged
kcondon merged 2 commits intoIQSS:developfrom
tcoupin:5225-credential-store-key-insteadof-value
Oct 31, 2018
Merged

Fix #5225 - Crendential store bundle key instead of value#5244
kcondon merged 2 commits intoIQSS:developfrom
tcoupin:5225-credential-store-key-insteadof-value

Conversation

@tcoupin
Copy link
Member

@tcoupin tcoupin commented Oct 29, 2018

Related Issues

Pull Request Checklist

@coveralls
Copy link

coveralls commented Oct 29, 2018

Coverage Status

Coverage decreased (-0.004%) to 15.612% when pulling 8fc6b22 on tcoupin:5225-credential-store-key-insteadof-value into bf22f94 on IQSS:develop.

Copy link
Contributor

@mheppler mheppler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just browsing the files changed log in this PR, this looks like a sound solution that follows similar methods of delivering bundle values to backing bean logic.

@pdurbin
Copy link
Member

pdurbin commented Nov 1, 2018

Unfortunately, I think this pull request caused a regression: #5260.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants